Support absolute height, scrollbar, pageup, and pagedown #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alan2wong |
…g the drop down to show a scrollbar if necessary. Also added pageup and pagedown functionality.
|
Rebased. As a note, in case you were wondering why I used height rather than the number of items as the option, this is so that the list items can be set to any size (rather than requiring a constant height). The scroll code is not dependent on the list items all being the same size. |
|
Thanks for rebasing and sorry for late reply. It looks good to me. |
yuku
added a commit
that referenced
this pull request
Aug 6, 2014
Support absolute height, scrollbar, pageup, and pagedown
yuku
added
the
DEPRECATED jquery-textcomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option object has the new height option set, a scrollbar will be visible if necessary. Scrolling via up, down, pageup, pagedown is supported along with all edge cases (if the selected value being transitioned from is above or below the visible items, or if we are going between the first and last items).
Also fixed an issue with the mouse hover not actually affecting the selected item. This now follows how a standard select tag behaves, although it was not possible to force remove the hover style.